Closed kerams closed 4 years ago
That failure again, hmmm.
Let me give it a try locally,
it is actually a lot easier for me to try out if you make a branch in the repo itself rather than from a fork :wink:
Works locally like a charm 😍 thanks a lot! I published Server
and its dependants to nuget and it should be available soon. Also published the docs to the Github pages from #178 when you update the docs, you need to run npm run publish
from the ./documentation
directory :smile:
So I should forget the fork and work in a local branch and create PRs from there to master?
Yeah it is easier like that 😄
For
statsApiHandler
requests, implementations for the first 4 handlers would be unnecessarily created ifFromContext
is used, which could be wasteful if those have expensive dependencies. A newMemoryStream
would be allocated for each of the 4 too, regardless of the fact whether routes match or not.