Add Set<'T> to Fable.Remoting.MsgPack

Zaid-Ajaj / Fable.Remoting

Type-safe communication layer (RPC-style) for F# featuring Fable and .NET Apps

https://zaid-ajaj.github.io/Fable.Remoting/

MIT License

272 stars 54 forks source link

Add Set<'T> to Fable.Remoting.MsgPack #184

Closed Shmew closed 3 years ago

Shmew commented 3 years ago

Adds Set<'T> for (de)serialization in MsgPack
Added the discussed fix to enable usage of the Write module via Fable
Added some missing test cases for Fable.Remoting (Set<'T>)

kerams commented 3 years ago

The set addition is great, but I'm not sure how I feel about the 2 Fables in the fully qualified of Write even though it certainly solves all the problems.

Shmew commented 3 years ago

Yeah, I'm not really happy with either of them. So whatever you and @Zaid-Ajaj want works for me. My assumption is that most people would open Fable.Remoting.MsgPack so it would be Fable.Write.writeObject which didn't seem too bad, but does feel a bit odd.

Zaid-Ajaj commented 3 years ago

The implementation and the tests look great to me. I had one minor comment about configuring the live integration tests, feel free to fix it or just leave it as is (I will fix it later) :smile: the rest looks ready to merge.

My assumption is that most people would open Fable.Remoting.MsgPack so it would be Fable.Write.writeObject which didn't seem too bad, but does feel a bit odd.

Yeah that sounds good!