search

Zaid-Ajaj / Fable.Remoting

Type-safe communication layer (RPC-style) for F# featuring Fable and .NET Apps
https://zaid-ajaj.github.io/Fable.Remoting/
MIT License
273 stars 55 forks source link

Added an option to set withCredentials #195

Closed Jmaharman closed 3 years ago

Jmaharman commented 4 years ago

When using Fable.Remoting with CORS it was not possible to validate the logged user with their cookie because it was not sent in the request.

Jmaharman commented 4 years ago

I couldn't think how to setup tests to prove that the browser behaves as I'd expect, as I would need to setup another website with CORS enabled and run that at the same time and make a request from the original site to the external site (accepting CORS).

It was such a simplistic change that it may be overboard.

Zaid-Ajaj commented 4 years ago

I couldn't think how to setup tests to prove that the browser behaves as I'd expect

It's alright, this change doesn't look harmful :smile: we will test it the good 'ol way, by publishing the the library and let you test on your machine

Jmaharman commented 3 years ago

I tested this locally by copying the necessary files into my .fable folder and it worked, so I'm confident once it's published that all should work as expected.

Zaid-Ajaj commented 3 years ago

Published as of Fable.Remoting.Client v7.1.0 💯

Jmaharman commented 3 years ago

Thanks Zaid