search

Zaid-Ajaj / Fable.Remoting

Type-safe communication layer (RPC-style) for F# featuring Fable and .NET Apps
https://zaid-ajaj.github.io/Fable.Remoting/
MIT License
272 stars 54 forks source link

Fix withCredentials = false not working #223

Closed KittisakT closed 3 years ago

KittisakT commented 3 years ago

Related issue #217

Zaid-Ajaj commented 3 years ago

Thanks a lot @KittisakT I don't how I missed that one 😓 just merged and published Fable.Remoting.Client v7.5 that includes the fix 🚀 should be on nuget in a moment 😄

kerams commented 3 years ago

WithCredentials is initialized to false so this also changes the current default behavior.

Zaid-Ajaj commented 3 years ago

Should we make initialization optional until the user provides a value? i.e. use bool option in the config? According to this, the default is false

kerams commented 3 years ago

That could still break something after upgrading for consumers that rely on the current ("incorrect/buggy") behavior. Then again, there's no way around it if we're going to follow the guidance you posted, which I'd be in favor of.

So in the end maybe just keep it as it is? Just felt like pointing out the potential problem 😄.

Zaid-Ajaj commented 3 years ago

Then again, there's no way around it if we're going to follow the guidance you posted, which I'd be in favor of.

I was thinking the same, we can't do much about it, will just keep it as is