search

Zaid-Ajaj / Fable.Remoting

Type-safe communication layer (RPC-style) for F# featuring Fable and .NET Apps
https://zaid-ajaj.github.io/Fable.Remoting/
MIT License
272 stars 54 forks source link

MsgPack DateTime timezone unsupported #227

Closed christoph-feb22 closed 3 years ago

christoph-feb22 commented 3 years ago

Hi there,

I'm using Fable.Remoting.MsgPack serialization. In the server we specify our DateTime objects with kind UTC. After sending them through Remoting to the client, the timezone kind is no longer UTC.

After checking the implementation I noticed that the transfered ticks are passed into the DateTime contstructor without any timezone kind. If I understand it correct, there is no possibility to transfer timezone specific DateTimes through MsgPack.

Did I missed something or is this the expected behaviour?

Kind regards Christoph

Zaid-Ajaj commented 3 years ago

Hi there @christoph-feb22, I will have a look it at. Right now, you can try using DateTimeOffset instead which should carry timezone offset correctly. Will keep you posted

christoph-feb22 commented 3 years ago

Hi @Zaid-Ajaj, thank you for the fast response. I will try to use DateTimeOffset.

kerams commented 3 years ago

@Zaid-Ajaj, I'll gladly take care of this if you haven't already started and don't feel like doing it.

Zaid-Ajaj commented 3 years ago

@kerams I gave it ago because I wanted to learn a bit more about the MsgPack implementation 😄 would be great if you could have a look at the PR at #228 🙏

Zaid-Ajaj commented 3 years ago

Hi @christoph-feb22 this issue should be fixed as of latest clients and backend adapters

Please update both your client and backend packages. Would be if you could confirm that the problem is resolved 😄

christoph-feb22 commented 3 years ago

Hi @Zaid-Ajaj, thank you very much for your incredible fast solution. It works like a charm!