search

Zaid-Ajaj / Fable.Remoting

Type-safe communication layer (RPC-style) for F# featuring Fable and .NET Apps
https://zaid-ajaj.github.io/Fable.Remoting/
MIT License
272 stars 54 forks source link

Add cancellation support #238

Closed do-wa closed 3 years ago

do-wa commented 3 years ago

Hi,

I've created a basic implementation of cancellation support by leveraging the f# async implicit token passing. I think the unit test shows a simple application for this.

I'm making this a draft since I'm not sure if the integration is missing some key points or violates some guidelines for this project.

Hope this helps.

Zaid-Ajaj commented 3 years ago

Hi @do-wa this actually looks great and the integration test too 💯

@kerams Any thoughts?

@do-wa It is a small thing but can you please fix the code indentation to make it consistent?

kerams commented 3 years ago

Looks good though I am admittedly not too familiar with token passing in asyncs.

do-wa commented 3 years ago

Sorry for the confusion. I've talked to @schauerte and we decided to include his changes in my PR. I hope I got this indentation stuff sorted out correctly.

Zaid-Ajaj commented 3 years ago

Thanks a lot! Merged and published as of v7.9 🚀