Zaid-Ajaj / Fable.Remoting

Type-safe communication layer (RPC-style) for F# featuring Fable and .NET Apps
https://zaid-ajaj.github.io/Fable.Remoting/
MIT License
272 stars 54 forks source link

MsgPack: converting types that contain char fails #244

Closed Zaid-Ajaj closed 3 years ago

Zaid-Ajaj commented 3 years ago

While I was updating remoting client to include the fix of char deserialization issue at Fable.SimpleJson/#71 I added a test for IBinaryServer and it failed the following test that deals with char

// TODO: implement char conversion in MsgPack
// testCaseAsync "IBinaryServer.echoRecordWithChar" <|
//     async {
//         let input = { CharValue = '*' }
//         let! output = binaryServer.echoRecordWithChar input
//         test.equal input.CharValue output.CharValue
//     }

@kerams Could you maybe please have a look at the problem 🙏 ? if you don't have time, I could pick it up at some point soon

Zaid-Ajaj commented 3 years ago

Fixed by #245 and included in Fable.Remoting.MsgPack as of v1.10.0