Refactor JS client proxy

Zaid-Ajaj / Fable.Remoting

Type-safe communication layer (RPC-style) for F# featuring Fable and .NET Apps

https://zaid-ajaj.github.io/Fable.Remoting/

MIT License

272 stars 54 forks source link

Refactor JS client proxy #246

Closed kerams closed 3 years ago

kerams commented 3 years ago

Cleaned up unused code, merged almost duplicate branches, and moved some static data out of fun arg0 arg1 arg2 arg3 arg4 arg5 arg6 arg7 -> so that it isn't recomputed on every request.

Zaid-Ajaj commented 3 years ago

Hi @kerams this one looks good, do you know if it resolve #249? 'Cause I don't see checking for a specific status code of zero

kerams commented 3 years ago

No, that stuff is in the Http module. This PR should not include any functional changes.

Zaid-Ajaj commented 3 years ago

Working on a fix that removes the check status code <> 0 the Http module and will push out a new version.