search

Zaid-Ajaj / Fable.Remoting

Type-safe communication layer (RPC-style) for F# featuring Fable and .NET Apps
https://zaid-ajaj.github.io/Fable.Remoting/
MIT License
272 stars 54 forks source link

Internalize TypeShape, take #2 #252

Closed kerams closed 3 years ago

kerams commented 3 years ago

Any ideas about excluding the two files from the Nuget package? In the worst case scenario, we can always do #if !FABLE_COMPILER.

Zaid-Ajaj commented 3 years ago

Any ideas about excluding the two files from the Nuget package?

You can conditionally Compile the files based on the FABLE_COMPILER constant I believe so that Fable won't compile them but I guess compiler directives like #if !FABLE_COMPILER in the files themselves are better because then the tests would catch any funky business that is otherwise not visible until someone pulls the nuget and it breaks on their machine

kerams commented 3 years ago

Added. The files will still be shipped, but I guess it's no biggie.

Zaid-Ajaj commented 3 years ago

A fresh batch is published to include this fix, let's see if the SAFE template issue with 32-bit apps is fixed 🤞