Closed matthewcrews closed 2 years ago
The parsing of the TimeSpan type is transferring the value in terms of number of milliseconds stored as int. This will cause an error when trying to make an RPC call with a TimeSpan who's number of milliseconds exceed the range of int.
TimeSpan
int
I believe the issue is here: https://github.com/Zaid-Ajaj/Fable.Remoting/blob/726303ce60a7e24e9d50fbd83ecac82fe42af143/Fable.Remoting.Json/FableConverter.fs#L491
I believe that it can be fixed by converting to a float instead of an int. I believe this per the docs here: https://docs.microsoft.com/en-us/dotnet/api/system.timespan.frommilliseconds?view=net-5.0
float
I will see if I can create my own PR to address the issue. I'll reference this issue in the PR.
Fixed in #277 thanks again 🙏 I'll add some integration tests later for this
The parsing of the
TimeSpan
type is transferring the value in terms of number of milliseconds stored asint
. This will cause an error when trying to make an RPC call with aTimeSpan
who's number of milliseconds exceed the range ofint
.I believe the issue is here: https://github.com/Zaid-Ajaj/Fable.Remoting/blob/726303ce60a7e24e9d50fbd83ecac82fe42af143/Fable.Remoting.Json/FableConverter.fs#L491
I believe that it can be fixed by converting to a
float
instead of anint
. I believe this per the docs here: https://docs.microsoft.com/en-us/dotnet/api/system.timespan.frommilliseconds?view=net-5.0I will see if I can create my own PR to address the issue. I'll reference this issue in the PR.