search

Zaid-Ajaj / Fable.Remoting

Type-safe communication layer (RPC-style) for F# featuring Fable and .NET Apps
https://zaid-ajaj.github.io/Fable.Remoting/
MIT License
272 stars 54 forks source link

Work around stackalloc codegen bug #305

Closed kerams closed 2 years ago

kerams commented 2 years ago

https://github.com/Zaid-Ajaj/Fable.Remoting/issues/304, https://github.com/dotnet/fsharp/issues/13447

sWW26 commented 2 years ago

Any chance this could get this merged & released?

kerams commented 2 years ago

@Zaid-Ajaj, v1.17 with this fix sets an upper constraint on FSharp.Core for some reason. Any idea how this happened?

image

Zaid-Ajaj commented 2 years ago

@kerams I think latest paket is more strict when you say nuget FSharp.Core ~> 4.7.2 it means >= 4.7.2 && < 4.8 but previously it didn't do that. Now I've changed the requirement to nuget FSharp.Core >= 4.7.2 with strategy lowest_matching: true and published a new batch so it should be alright I think 🤞

In any case, huge thanks for the fix 🙏 I would not have known how and where to start fixing this 😅

@sWW26 A new batch of remoting packages have been published 🚀 , when upgrading, please make sure to update both client and server when doing so.

sWW26 commented 2 years ago

That's great. Thanks both!