Closed kerams closed 1 year ago
OK you can ignore my comments, the inlining is still needed and I believe you cannot make the function body private when we do that.
Yep, without inline
Fable cannot insert the type object, and with inline
the extracted method has to be public. I chose not to call it something like buildProxyInternal
, so that it does not stand out in Intellisense. I thought it was a small price to pay for potentially reducing duplication in the bundle.
Published as of Fable.Remoting.Client v7.22
Support for type injection is removed from Fable(.Core) 4, hence this workaround.
I've thought about dropping the Fable 2 tests and adding 4, but versions 3 and 4 of the compiler are distributed as dotnet tools and I don't think it's possible to have multiple versions side-by-side.