Zaid-Ajaj / Fable.Remoting

Type-safe communication layer (RPC-style) for F# featuring Fable and .NET Apps
https://zaid-ajaj.github.io/Fable.Remoting/
MIT License
272 stars 55 forks source link

Accept Task-returning methods in JSON serialization #333

Closed kerams closed 1 year ago

kerams commented 1 year ago

This problem is hit only with JSON serialization when the contract file is in a separate project (which we don't use in tests here, so I can't add a case without creating extra projects - but I did try it though :)).

@lukaszkrzywizna

Zaid-Ajaj commented 1 year ago

This could go into Fable.SimpleJson (TypeInfo.Task), but I assumed you wouldn't want it there as tasks aren't supported in Fable.

Ideally, it should go in SimpleJson just like Async/Promise but that can be done later 😄 now merged and published as of Fable.Remoting.Client v7.25 🚀

lukaszkrzywizna commented 1 year ago

It works like a charm! Thanks! <3