search

Zaid-Ajaj / Feliz

A fresh retake of the React API in Fable and a collection of high-quality components to build React applications in F#, optimized for happiness
https://zaid-ajaj.github.io/Feliz/
MIT License
544 stars 81 forks source link

Pigeonmaps onAnimationEnd not working #500

Closed Steinar30 closed 2 years ago

Steinar30 commented 2 years ago

Hi! I have an issue with the onAnimationEnd event not firing properly, while the onAnimationStart functions as expected.
I think this is caused by the bindings generating onAnimationEnd instead of onAnimationStop, as is used by the pigeonmaps library.

The fix for this is probably just to update the generated string, and potentially rename the exposed function.

https://github.com/Zaid-Ajaj/Feliz/blob/dc697c879600c1387bc6a43ee3ede4609a1be5f2/Feliz.PigeonMaps/Map.fs#L66

Zaid-Ajaj commented 2 years ago

Hi there @Steinar30, thanks for filing the issue 🙏 fixes as of Feliz.PigeonMaps v2.6.0 which makes onAnimationEnd obsolete and refers users to onAnimationStop