search

Zaid-Ajaj / Feliz

A fresh retake of the React API in Fable and a collection of high-quality components to build React applications in F#, optimized for happiness
https://zaid-ajaj.github.io/Feliz/
MIT License
540 stars 78 forks source link

Use Fable.React.Types dependency #509

Closed alfonsogarciacaro closed 1 year ago

alfonsogarciacaro commented 2 years ago

@Zaid-Ajaj This is the change discussed in #508 (PR also moves some XML comments to avoid warnings during build). Tests seem to be passing. I wasn't expecting docs to work because of the Fable.Elmish.React dependency but a bit surprisingly they do build. Although I do get a runtime error when trying to run them in a local server. I will send a similar PR to Fable.Elmish.React and try again.

Note: I've also added the README file to the packages and the Fable logo. But of course, feel free to discard that if you don't want to use the same README for all packages or if you want to use a different logo.

Zaid-Ajaj commented 1 year ago

Merged and published as of Published Feliz v2.0.0-prerelease-003 🚀