search

Zaid-Ajaj / Feliz

A fresh retake of the React API in Fable and a collection of high-quality components to build React applications in F#, optimized for happiness
https://zaid-ajaj.github.io/Feliz/
MIT License
540 stars 78 forks source link

Missing Recharts properties #516

Closed sydsutton closed 1 year ago

sydsutton commented 1 year ago

Hello,

I have recently added some properties that I needed for Recharts.tooltip, barChart, and labelList to a project of mine. Would it be okay if I created a PR with those added so that you can review them?

Thanks.

Zaid-Ajaj commented 1 year ago

I have recently added some properties that I needed for Recharts.tooltip, barChart, and labelList to a project of mine. Would it be okay if I created a PR with those added so that you can review them?

Yes please! Contributions are always welcome 🙏

sydsutton commented 1 year ago

Yes please! Contributions are always welcome 🙏

Great, thank you. PR sent! Please double check tooltip.position-- that one was tricky for me.

sydsutton commented 1 year ago

Just so you know, Zaid, I just fixed some build errors in the PR but am still unsure of tooltip.position. I'm not sure how to set the default position based on the parent element/ mouse position. Thanks again.

Zaid-Ajaj commented 1 year ago

Resolved as of Feliz.Recharts v3.15 (in case using Feliz v1.68) or latest v4.0 when using Feliz v2.0 🚀