search

Zaid-Ajaj / Feliz

A fresh retake of the React API in Fable and a collection of high-quality components to build React applications in F#, optimized for happiness
https://zaid-ajaj.github.io/Feliz/
MIT License
534 stars 78 forks source link

Restrict Feliz.CompilerPlugins version required by Feliz 1 #554

Open MangelMaxime opened 1 year ago

MangelMaxime commented 1 year ago

Hello @Zaid-Ajaj,

Important: This PR is not to be merged into master but should instead go into a feliz1 branch. In theory, I created this branch on the latest commit related to v1.

This branch is related to #544. The goal of this branch is to push a new version of Feliz 1 which restrict Feliz.CompilerPlugin to version 1 only.

image

I had to use a custom MSBuild task because MSBuild doesn't support version restriction on ProjectReference out of the box.

https://github.com/NuGet/Home/issues/5556#issuecomment-1179526189

Zaid-Ajaj commented 8 months ago

Feliz v2 has been in use for a while now, I don't think I want to maintain a separate Feliz v1.x branch just for this 🤔 I would rather if users updated to Feliz v2 if they encountered issues with v1

MangelMaxime commented 7 months ago

@Zaid-Ajaj The problem, is that if they don't use the latest version of Fable 3 then they will only see the problem at the runtime only with some weird errors / behaviours. There was a bug in previous version of Fable 3 which allows to "skip" invalid plugins and keep the compilation going as normal when it should have failed.

We are speaking about a one time release, which can avoid them having to debug strange bugs.