search

Zaid-Ajaj / Feliz

A fresh retake of the React API in Fable and a collection of high-quality components to build React applications in F#, optimized for happiness
https://zaid-ajaj.github.io/Feliz/
MIT License
531 stars 77 forks source link

Fix line-height style property #611

Closed Linschlager closed 4 weeks ago

Linschlager commented 1 month ago

[!WARNING] This may break existing usages of the property, so proceed with caution

Currently, line-height interprets unitless int and float values as px. This is undesirable as there is also the unitless lineHeight property which is not available in the current overload structure.

This is especially bad since the unitless approach should be preferred whenever possible. (As per MDN https://developer.mozilla.org/en-US/docs/Web/CSS/line-height)

This proposed change removes the px from the existing overloads and adds additional documentation to the changed properties.

Zaid-Ajaj commented 3 weeks ago

Included in Feliz v2.8 🚀