search

Zaid-Ajaj / LiteDB.FSharp

Advanced F# Support for LiteDB, an embedded NoSql database for .NET with type-safe query expression through F# quotations
MIT License
181 stars 20 forks source link

testCases "Bson.readDate works" and "Reading Bson values as DateTime works" both fail #21

Closed akucheck closed 5 years ago

akucheck commented 5 years ago

On a fresh install, while running ./build.sh these 2 testCases fail on the Day conversion with an offByOne error.

I'm assuming this is due to a change to LiteDB but have not been able to confirm that yet.

litedb fsharp build errors

humhei commented 5 years ago

I can not repro it after i update LiteDB locally (All tests are passed) What's the exception does it throw?

humhei commented 5 years ago

You can set breakpoint these places to see what the error is https://github.com/Zaid-Ajaj/LiteDB.FSharp/blob/master/LiteDB.FSharp/Json.fs#L181 https://github.com/Zaid-Ajaj/LiteDB.FSharp/blob/master/LiteDB.FSharp/Json.fs#L249

akucheck commented 5 years ago

did not mean to close (sorry). after setting breakpoint at #181: debugging litedb fsharp-1

Zaid-Ajaj commented 5 years ago

Hello @akucheck,

I'm assuming this is due to a change to LiteDB but have not been able to confirm that yet.

I think this might be the case, I wil investigate, thanks a lot for reporting the issue :)

Zaid-Ajaj commented 5 years ago

@akucheck Seems to be fixed, can you pull a fresh clone and run the tests again? :smile:

please re-open the issue if the problem persists

akucheck commented 5 years ago

Happy to.

ak

On Tue, Jan 29, 2019 at 4:19 PM Zaid Ajaj notifications@github.com wrote:

@akucheck https://github.com/akucheck Seems to be fixed, can you pull a fresh clone and run the tests again? 😄

please re-open the issue if the problem persists

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Zaid-Ajaj/LiteDB.FSharp/issues/21#issuecomment-458761139, or mute the thread https://github.com/notifications/unsubscribe-auth/AADvyuMn5vYzAM57RipE-u5pRpi1QbMeks5vIOUGgaJpZM4aUiYz .

akucheck commented 5 years ago

Zaid-Ajaj:

Works like a champ. thanks!

ak

On Tue, Jan 29, 2019 at 4:19 PM Zaid Ajaj notifications@github.com wrote:

@akucheck https://github.com/akucheck Seems to be fixed, can you pull a fresh clone and run the tests again? 😄

please re-open the issue if the problem persists

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Zaid-Ajaj/LiteDB.FSharp/issues/21#issuecomment-458761139, or mute the thread https://github.com/notifications/unsubscribe-auth/AADvyuMn5vYzAM57RipE-u5pRpi1QbMeks5vIOUGgaJpZM4aUiYz .