Closed dbrattli closed 3 years ago
Hi Dag, is this PR ready for merging or are you planning for more modifications? 😉 Just let me know if you want a new release including these changes 😄
Zaid, this should be ready for merging. There will probably be more PRs, but I don't have anything else right now. One thing you can think about is if you want the comments to be part of the AST or skipped for now as with this PR.
Hi @dbrattli I just published a new batch of packages v3.26 that include updates both to the parser and the SDK. The analyzer should work now with Ionide on VS Code (fingers crossed)
These updates also update the target framework to net5.0 (latest) can you check that the package still works for you? if it doesn't work, then I can publish the parser separately targeting netstandard2.0
@Zaid-Ajaj Thanks for publishing! We're currently using a fork of the code to unblock ourselves, but with the goal of keeping the parser in sync and publishing every change back so we can contribute to this great project (e.g #32). When the dust settles we will go back to using this library as a nuget again. I'll try to use it with vscode again. I'll let you know how it goes!
Thanks @dbrattli 🙏
Btw the vs code integration is (still) failing right now, it has something to do with latest vs code changes and I confirmed it with the maintainers of ionide. I will be looking into it shortly
Proposed Changes
Add support for quoted column references in SELECT statements e.g:
Add support for correlation (see 4.2.1) quoted column references e.g:
and mixed quoted/unquoted column references e.g:
The change keeps the identifiers as a string thus having quoted schema/table/column names containing dots (
.
) will most likely give unexpected behavior. But this makes the change non-breaking by keeping the format of identifiers compatible with before i.eschema.table.column
as a string.Also add support for comments, both
/* .. */
and-- ...
.Types of changes
What types of changes does your code introduce to BinaryDefense.FSharp.Analyzers? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...