Closed dbrattli closed 3 years ago
PS: Might be breaking change because of Integer of int64
.
PS: Might be breaking change because of Integer of int64.
It should be alright, the analyzer does not need to check the contents of the constants for now ✔️
Thanks again for improving the parser, I will make use of these features for the next release!
Proposed Changes
Add support for:
... IN (1,2,3)
. Not the same as array.Types of changes
What types of changes does your code introduce to BinaryDefense.FSharp.Analyzers? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...