search

Zaid-Ajaj / Snowflaqe

A dotnet CLI to generate type-safe GraphQL clients for F# and Fable with automatic deserialization, static query verification and type checking
MIT License
154 stars 25 forks source link

Updated dependencies, added netstandard2.0 support and added .editorconfig #46

Closed anthony-mi closed 3 years ago

xperiandri commented 3 years ago

@Zaid-Ajaj after updating to the latest FsAST and Fantomas code has changed a bit (see tests). We are going to update the etalon code in tests that is used for comparison. OK?

xperiandri commented 3 years ago

Not entirely sure because it is taking away documentation from the generated code.

@Zaid-Ajaj explain, please, what do you mean by that. What exactly the issue we introduced by this update?

xperiandri commented 3 years ago

Adding netstandard2.0 support?

It will probably be required for MSBuild task. We still experimenting with that.

Zaid-Ajaj commented 3 years ago

Not entirely sure because it is taking away documentation from the generated code.

@Zaid-Ajaj explain, please, what do you mean by that. What exactly the issue we introduced by this update?

In the tests (for example file tests/SampleHasuraSchema.fs) I see that the generated code no longer has XML documentation for the generated types so I am assuming these aren't being generated?

Right now, I am really low on time/capacity to look into the PR properly to see what's going on 😞 I will try to give it a try soon

anthony-mi commented 3 years ago

In the tests (for example file tests/SampleHasuraSchema.fs) I see that the generated code no longer has XML documentation for the generated types so I am assuming these aren't being generated?

By XML documentation you mean comments like fetch data from the table: "userOrders"?

Zaid-Ajaj commented 3 years ago

By XML documentation you mean comments like fetch data from the table: "userOrders"?

Yes, the lines that start with /// are important to the generated code

xperiandri commented 3 years ago

@Zaid-Ajaj looks like errorTypeName is not used https://github.com/Zaid-Ajaj/Snowflaqe/blob/c09a1e3905543cbd5b31481073bf99e7b2ea46f0/src/CodeGen.fs#L772

Zaid-Ajaj commented 3 years ago

Superseded by #48