Implemented support for System.text.Json

[Zaid-Ajaj]

I just realized this PR adds the FSI files with method signatures only for the constructor. Shouldn't the fsi signature files also emit the generated method names?

[xperiandri]

No, it is not mandatory. Only the members that require modification can be put into fsi

[Zaid-Ajaj]

No, it is not mandatory. Only the members that require modification can be put into fsi

@xperiandri What is then the idea behind adding such a file? Isn't this to improve compiler performance by typing out the definitions beforehand?

@dim-37 Sorry the build is still broken because the Fable build target is using HttpClient (and more non-Fable specific things)

There are still hardcoded client names...

[xperiandri]

What is then the idea behind adding such a file? Isn't this to improve compiler performance by typing out the definitions beforehand?

I cannot add XML comment to default constructor any other way

[Zaid-Ajaj]

I cannot add XML comment to default constructor any other way

All of the code is auto-generated, you could easily add an option for the docs of the client

[xperiandri]

I cannot add XML comment to default constructor any other way

All of the code is auto-generated, you could easily add an option for the docs of the client

I don't understand what you mean

[Zaid-Ajaj]

I mean you can just another configuration option for the xml docs of the client instead of the fsi file

[xperiandri]

In that case, we will need to use only explicit constructors instead of the default one. I thought that adding fsi is simpler 🙂

[xperiandri]

@Zaid-Ajaj do we fixed the remaining comments?

[Zaid-Ajaj]

@anthony-mi @xperiandri I will have another look