search

Zaid-Ajaj / Snowflaqe

A dotnet CLI to generate type-safe GraphQL clients for F# and Fable with automatic deserialization, static query verification and type checking
MIT License
154 stars 25 forks source link

Implemented MSBuild task #51

Closed dim-37 closed 2 years ago

dim-37 commented 2 years ago

Since we use JsonSerializer.DeserializeAsync, which returns ValueTask, we need to use this part of the code from FSharp.Control.FusionTasks, should we copy this code into the project or can we add FSharp.Control.FusionTasks as reference? https://github.com/kekyo/FSharp.Control.FusionTasks/blob/06b81062bf5ba628245a7392e55676a43490b10a/FSharp.Control.FusionTasks/Infrastructures.fs#L103 https://github.com/kekyo/FSharp.Control.FusionTasks/blob/06b81062bf5ba628245a7392e55676a43490b10a/FSharp.Control.FusionTasks/AsyncExtensions.fs#L92 What do we need to do?

xperiandri commented 2 years ago

We are testing it yet (System.Text.Json scenario), I'll notify when ready

Zaid-Ajaj commented 2 years ago

@xperiandri Can you please rebase on master / resolve the merge conflicts as well?

dim-37 commented 2 years ago

I am deleting the generation of the fsi files because they are not needed now that the default builder has comments https://github.com/Zaid-Ajaj/Snowflaqe/blob/25903aca2f7f6153d8f0a822b91e59ddedfd1eb5/src/CodeGen.fs#L1427