ZakBlystone / gmod_blueprints

Blueprint Editor for Garry's Mod (Visual Programming)
GNU General Public License v3.0
59 stars 9 forks source link

deleting an object in a project that has functions referenced in other objects can brick the project #63

Closed Crysoskis closed 4 years ago

Crysoskis commented 4 years ago

Sometimes deleting an object that has functions referenced in other objects can brick the entire project or just cause issues in general

Uploading to server causes console flooding: image

And can trigger visual glitches: image

image

Has a chance to break blueprints: image AmmoDropper tabs cannot be closed, and appear as empty when viewed. script errors happen when one is opened.

How to reproduce:

  1. Create new project
  2. Create a new object, name it Test1
  3. Create another object, name it Test2
  4. Create a function that does something in Test1
  5. Call Test1's function in Test2
  6. Save and upload
  7. Delete the Test1 Object
  8. Save and upload
  9. Bug occurs. Can brick a project until the server restarts. Has a chance to permanently brick a project.

Bricked project: bp-wDBaUyZzR98lspxGEunX Object DebugMod bricked this blueprint after it was deleted.

ZakBlystone commented 4 years ago

Fixed in commit 45dd42ec534c3351f12a22438e5a58346c7d2e6e Will integrate into v2-stable after some testing.