search

Zal0 / ZGB

Game Boy / Color engine with lots of features
MIT License
706 stars 50 forks source link

Error with ZGB-Template with the latest version #13

Closed aiguanachein closed 5 years ago

aiguanachein commented 5 years ago

Hello! First of all, thanks for this wonderfull engine.

I've got a problem with the latest version, I've updated engine and game code to work with it, but I cannot compile any of the test i was making before all the changes in the engine were made. I try to redownload all and configure again and with the new template, but the results are the same. If I restore the previous game code and ZGB enviroment, everything is Ok.

There goes an attachement with the result:

imagen

Thanks in advance!

`C:\ZGB\proyectos\ZGB-template-master>cd src

C:\ZGB\proyectos\ZGB-template-master\src>c:/ZGB/common..\env\make-3.81-bin\bin\make run El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. Creating folder ../res/src La sintaxis del comando no es correcta. Error writing fileCreating folder ../Release/zgb La sintaxis del comando no es correcta. common..\env\make-3.81-bin\bin\make: *** [../Release/zgb] Error 1

C:\ZGB\proyectos\ZGB-template-master\src>cd ..

C:\ZGB\proyectos\ZGB-template-master>pause Presione una tecla para continuar . . .`

cubicstyle commented 5 years ago

The problem is this fix. https://github.com/Zal0/ZGB/commit/8b2077b7859690ec5fe280520f664b0a60e301c9#diff-67bceb39f464519af34902eaf124b443

Change ":" back to ";" in PATH. Then you can build.

Zal0 commented 5 years ago

That shouldn't be an issue using colons instead of semicolons is the standard way to set the path (and it works for me)

Zal0 commented 5 years ago

Hello! First of all, thanks for this wonderfull engine.

I've got a problem with the latest version, I've updated engine and game code to work with it, but I cannot compile any of the test i was making before all the changes in the engine were made. I try to redownload all and configure again and with the new template, but the results are the same. If I restore the previous game code and ZGB enviroment, everything is Ok.

There goes an attachement with the result:

imagen

Thanks in advance!

`C:\ZGB\proyectos\ZGB-template-master>cd src

C:\ZGB\proyectos\ZGB-template-master\src>c:/ZGB/common..\env\make-3.81-bin\bin\make run El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada. Creating folder ../res/src La sintaxis del comando no es correcta. Error writing fileCreating folder ../Release/zgb La sintaxis del comando no es correcta. common..\env\make-3.81-bin\bin\make: *** [../Release/zgb] Error 1

C:\ZGB\proyectos\ZGB-template-master\src>cd ..

C:\ZGB\proyectos\ZGB-template-master>pause Presione una tecla para continuar . . .`

It's not clear to me what the problem is beacuse I cannot see the full log Does the latest version of the template work for you?

I have been making a lot of changes in the recent weeks that I'm sorry but are not backwards compatible. If it is an old project that you were working on you probably need to make a few changes in the code to make it work again. I can help you if you send me a link of your projects

aiguanachein commented 5 years ago

The error occurs just compiling the new template, without any changes in the code. I followed the installation guide point by point. I understand that the new template should still work "as is" as shown here. It's strange, cause if I put back the old template and old ZGB folder it works.

Zal0 commented 5 years ago

Did the solution provided by cubicstyle work for you?

aiguanachein commented 5 years ago

I will try in a couple of hours (I'm not at home now xD) and post the result. Thanks to all!

cubicstyle commented 5 years ago

I'm using Windows 10. back to colon in PATH, build failed.

Zal0 commented 5 years ago

Windows 10 also here and no problems at all... are you using msys2?

cubicstyle commented 5 years ago

msys2 is installed. not used for build it.

aiguanachein commented 5 years ago

Working with the solution provided by @cubicstyle, at least on Windows 7. I will try later on Win 10.

aiguanachein commented 5 years ago

Works on Win 10 (1903) too.

cubicstyle commented 5 years ago

I tried on another Windows 10 PC, it was same build error.

my windows lang environment is Japanese. may be set lang other than English. zgb_error

Zal0 commented 5 years ago

Using semicolons fails on that japanesse computer? I was about to revert that commit

cubicstyle commented 5 years ago

yes, I can build by modify to semicolons.

@aiguanachein is also not English environment.

Zal0 commented 5 years ago

Tested with msys2 on my computer and no issues at all Did you guys modified the content of the env folder? are you still using make 3.81 for Windows?

aiguanachein commented 5 years ago

@Zal0 No, is just unzipped from the link provided. And in my case as far as I know i'm not using msys2.

Zal0 commented 5 years ago

Ok, I have reverted the changes. I'll review this for Linux when the time comes, in the meantime I want this working on Windows without problems Thank you guys for your help!