Zal0 / ZGB

Game Boy / Color engine with lots of features
MIT License
694 stars 51 forks source link

Failure to use music #55

Closed p1nhead98 closed 1 year ago

p1nhead98 commented 1 year ago

I declare the music and use it as indicated in the documentation but I get this error when I save a song .uge in the res/music folder

sus

aiguanachein commented 1 year ago

Same here!

nygator commented 1 year ago

Are you using hUGEtracker 1.0b10? Because that's not compatible with ZGB right now. The new version changed how the music format works. I fixed this by manually compiling all the music into c files and putting them into the /Debug/res/ folder and manually replacing the driver with a new one, then realised how much work this is and just switched back to hUGEtracker 1.0b9.

I hope Zal0 adds an option to switch between different sound drivers and hUGEtracker versions... :\

aiguanachein commented 1 year ago

I tried with one of the sample songs that come in the package hUGETracker 1.0 Beta 9.zip (renamed to test.uge), but it doesn't seem to work either. error

ItsMeSousuke commented 1 year ago

When I removed from https://github.com/Zal0/ZGB/blob/master/common/include/hUGEDriver.h all the OLDCALL, it starts working. What was the reason of adding that OLDCALL to the code?

Zal0 commented 1 year ago

When I removed from https://github.com/Zal0/ZGB/blob/master/common/include/hUGEDriver.h all the OLDCALL, it starts working. What was the reason of adding that OLDCALL to the code?

You need that to use the latest GBDK

ItsMeSousuke commented 1 year ago

So how it's possible that it works without it, because all the other things all compiled before and are not recompiled?

greenwebsevilla commented 1 year ago

So how it's possible that it works without it, because all the other things all compiled before and are not recompiled?

This works for me: removing the OLDCALLs to compile the song, then I have to restore the OLDCALLs to make it sound fine. It is not the best solution, but it works for now. I will test it during the development. I case I find any issue or a better solution I will write here.

wirehack7 commented 1 year ago

So how it's possible that it works without it, because all the other things all compiled before and are not recompiled?

This works for me: removing the OLDCALLs to compile the song, then I have to restore the OLDCALLs to make it sound fine. It is not the best solution, but it works for now. I will test it during the development. I case I find any issue or a better solution I will write here.

How exactly is your process there? Removing oldcalls and then only compile the song? And then restoring oldcall and compiling the project?

greenwebsevilla commented 1 year ago

Yes, that is basically what I do. The problem is only when you try to compile a new song and the oldcalls are present. So you can have the oldcalls all the time except when you add or modify a song.

Message ID: @.***>

Zal0 commented 1 year ago

Adding #include <gb/gb.h> into hUGEDriver.h fixes the issue
The problem is that OLD_CALL needs that include to compile

I have fixed this now