Zallist / unity.zallist.universal-simple-lit-shadergraph-target

This plugin simply adds a Simple Lit material (SubTarget) to the Universal target for Shader Graph for URP
Other
82 stars 14 forks source link

Get Unity to adopt this officially into URP ShaderGraph #4

Open Zallist opened 2 years ago

Zallist commented 2 years ago

Since I don't want to support it forever. If someone has an "in" to the URP team, just tell them to take this code verbatim and officially support it.

bmourit commented 2 years ago

Good luck. I've been hounding them forever as to why this was ever missing. Maybe we can get some attention in the forums? I'm also currently working on BakedLit for ShaderGraph, mainly since I want to use a combo of the URP UberShaders along with ShaderGraphs that will consistently match them when needed. Seems like it should have been that way from the start, but I dunno...

Zallist commented 2 years ago

I've raised a request to Unity to absorb this via their product board at https://portal.productboard.com/unity/1-unity-platform-rendering-visual-effects/tabs/3-universal-render-pipeline

Since 95% of the work is done already, maybe they'll just take it and run with it.

Zallist commented 2 years ago

100% of the work, now. Unity, just copy/paste the code in.

Zallist commented 2 years ago

Hey Unity, I've restructured this so it's now the exact same directory structure as the Universal Render Pipeline's. So you can literally just download the files and put them in, and the only thing you have to change is the Includes/ path in the UniversalSimpleLitSubTarget.

bmourit commented 2 years ago

I notice others have made pull requests on Github that Unity has merged, but they are mostly in the form of fixes. Did you want to try doing a pull request?

mehmet-soyturk-qonic commented 1 year ago

https://forum.unity.com/threads/shadergraph-simplelit-target.1440913/