Implement backwards compatibility changes for URP 12

Zallist / unity.zallist.universal-simple-lit-shadergraph-target

This plugin simply adds a Simple Lit material (SubTarget) to the Universal target for Shader Graph for URP

Other

85 stars 14 forks source link

Implement backwards compatibility changes for URP 12 #5

Closed Zallist closed 2 years ago

Zallist commented 2 years ago

@bmourit on issue https://github.com/Zallist/unity-universal-shadergraph-extensions/issues/3 has pointed out that this Simple Lit shader does NOT work on URP 12. This issue encompasses the work to getting it to work:

#if checks in C# code so that BlendModePreserveSpecular is stripped before unity 2022
keyword or safety check in hlsl to remove the blendmode code

bmourit commented 2 years ago

Great. I'll leave the current code & comment out differences between this and the PBRForwardPass/PBRGBufferPass for ease of updating. I've switched all to Unity's namespaces as well, for reasons you stated in the closed issue. I think I've found a simple solution to my GBuffer issue as well, and it doesn't require any new methods. Thanks again for doing this, it is really needed & much requested. I'm sure it will help many!

Zallist commented 2 years ago

Should be fixed in #6