Zamenhof / api

Public repo for issues and wiki.
0 stars 0 forks source link

Invalid JSON #42

Open nftl-agnieszka opened 5 years ago

nftl-agnieszka commented 5 years ago

If within text field - response teacher uses 'Enter' button to separate text; JSON is no longer valid. Please see the following screen. We have encounter that situation today for one of our student who received invalid xapi statements (scored statement). Could you please double check that issue?

image

indrajitlahiri commented 5 years ago

I have posted some protection to avoid the line break, lets see how this works now in the next lesson.

nftl-agnieszka commented 5 years ago

@indrajitlahiri resolution does not work. After that fix we did not receive any xapi statements. Please double check and deploy any fix/improvement to test environment first. Once deployed we will test it. Once we confirm that tests are fine and there is no regression we can go to production.

indrajitlahiri commented 5 years ago

@nftl-agnieszka the change in teacher zoom call box for attendance and grade is rolled back soon after your spot on Oct 9th and informed in slack. The api are posted in the address as following https://prod.aws.nftl.cloud/xapi-zamenhof/xapi-gateway/v1.0/publish/ It is actually the same file there as before the change was made. If still it is not receiving xapi posts then might something else changed at your side.

We had posted the change in the dev only and informed that too in slack requested for a testing at your side in dev environment. So the changed new version is in dev only since 9th Oct, and the prod has the original before version.

nftl-agnieszka commented 5 years ago

@Indra I was testing putting enters in teacher's command field. It works now. Even if enter is used in text field we receive both xapi statements. We can go to production with that fix. Can we deploy it tomorrow ?

indrajitlahiri commented 5 years ago

@nftl-agnieszka it is deployed in production.