Zamiell / stardew-valley

GNU General Public License v3.0
105 stars 79 forks source link

Convert compass directions to screen directions #22

Closed hawstom closed 2 years ago

hawstom commented 2 years ago

Change compass directions to up, down, left, right. I don't like this, but it's what was requested.

Zamiell commented 2 years ago

thank you!

I don't like this

i acknowledge that we could go either way with this. but I feel like assuming that north actually maps to "up" on a 2d game like this probably doesn't make sense, since it is possible that the camera is simply pointing in the opposite direction that you think it is, and there are no in-game references to north, south, east, or west, correct me if i am wrong

hawstom commented 2 years ago

I will be paying attention and let you know. :-D

Tom Haws 480-201-5476 (or NPS 480-389-4583) "Forgiveness is the highest and most beautiful form of love. In return, you will receive untold peace and happiness." -Dr. Robert Muller

On Fri, Jan 21, 2022 at 6:49 PM James @.***> wrote:

thank you!

I don't like this

i acknowledge that we could go either way with this. but I feel like assuming that north actually maps to "up" on a 2d game like this probably doesn't make sense, since it is possible that the camera is simply pointing in the opposite direction that you think it is, and there are no in-game references to north, south, east, or west, correct me if i am wrong

— Reply to this email directly, view it on GitHub https://github.com/Zamiell/stardew-valley/pull/22#issuecomment-1019011828, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADSVB2DAXMBIRSV5JKGY3DUXIEJRANCNFSM5MRAP5UQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

hawstom commented 2 years ago

Here's what I recalled or found:

Intro: "... my pride and joy: ____ Farm. It's located in Stardew Valley, on the southern coast."

Living off the Land: "This one's for you folks living in Stardew Valley. Check for Spring Onion southwest of town, where the river meets the ocean. You can sometimes find a whole bunch growing right out of the dirt."

Ginger Island (conceivably special): "When dark clouds cry, begin your quest To seek the fabled gem-birds four Each day, one north, south, east, or west Arrange their gifts upon my door"

Misc. Golden Walnut hints speak similarly of the island.

Zamiell commented 2 years ago

ok, i reverse my position

Zamiell commented 2 years ago

using north/south/east/west is fine, if you would like to change it back, you can, its up to you (or if you want to use those words in future pull requests)

hawstom commented 2 years ago

OK. Maybe a "style guide" might be: "The guide uses compass directions except in some cases when talking about tool use." ?

Tom Haws 480-201-5476 (or NPS 480-389-4583) "Forgiveness is the highest and most beautiful form of love. In return, you will receive untold peace and happiness." -Dr. Robert Muller

On Sat, Jan 22, 2022 at 12:28 AM James @.***> wrote:

using north/south/east/west is fine, if you would like to change it back, you can, its up to you (or if you want to use those words in future pull requests)

— Reply to this email directly, view it on GitHub https://github.com/Zamiell/stardew-valley/pull/22#issuecomment-1019083686, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADSVBYQEP73UOLBZHOOOSDUXJMBPANCNFSM5MRAP5UQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

Zamiell commented 2 years ago

seems fine with me!