search

Zanduino / MAX31855

Read thermocouple temperature using a MAX31855 converter
GNU General Public License v3.0
4 stars 7 forks source link

Typo in the demo #14

Closed videobuff closed 11 months ago

videobuff commented 11 months ago

Expected Behavior

There is a typo in the demo. SO the compiler crashes

Actual Behavior

see above

Steps to Reproduce the Problem

Copy the demo and run it.

Explain what needs to be done in order to reproduce the problem. while (!MAX31855.begin(SPI_CHIP_SELECT,SPI_MISO,SPI_SYSTSEM_CLOCK)) // Software SPI for MAX31855 The tyope is in the SPI_SYSTSEM_CLOCK), which shoud be SPI_SYSTEM_CLOCK)

Specifications

SV-Zanshin commented 11 months ago

Hello @videobuff - The source code for the demo.ino here on GitHub doesn't have that error.

Where did you source the incorrect demo.ino code?

SV-Zanshin commented 11 months ago

It seems as if the package in the Arduino IDE is outdated. I'll create a new package version so that error goes away.

SV-Zanshin commented 11 months ago

I've created the new package that include this fix

SV-Zanshin commented 11 months ago

Done.

videobuff commented 11 months ago

Thanks, not a big problem but I am working on a project for a SMD soldering station and intend to publish that. B.t.w, do you think that i have to add levellers on SCK and CS, as well as a tri-state circuit on MISO ? I feed the sensors with 3.3.V from my ESP32 Wrover but i get somethimes very funny figures. I just loaded the IDE again, went to the MAX31955 demo and it is still there - see the pic. Will try again later

Scherm­afbeelding 2023-12-13 om 12 43 57
SV-Zanshin commented 11 months ago

The Arduino package updates can take time, I think about a day, before they are added to the library manager.

I've not had any anomalous behaviour or readings on my various Atmel-Arduinos during testing. Perhaps the ESP32 platform is more sensitive due to its higher speed? But the circuit shouldn't really need additional hardware to function correctly.