ZaneDubya / MP3Sharp

MP3 decoder in managed .NET code.
GNU Lesser General Public License v3.0
132 stars 46 forks source link

Skip ID3v2 tags without unsynchronisation. #14

Closed Juvwxyz closed 2 years ago

Juvwxyz commented 2 years ago

A ID3v2 tag without unsynchronisation may contain frame sync (0xFFF or 0xFFE), which may led false decodeing. Should we skip it in this library or let the user deal with it themselves?

ZaneDubya commented 2 years ago

Hello! Could you upload an example? Or send it to me at zanewagner@gmail.com. Many many thanks. -Zane

Juvwxyz commented 2 years ago

Hello! Could you upload an example? Or send it to me at zanewagner@gmail.com. Many many thanks. -Zane

Sure, you can download an example here: mp3 file with frame sync inside id3 tag. The MP3Sharp library cannot decode it corectly if you don't skip the id3 tag. To fix this is simple, just skip the tag in the constructor. Or can I open a pull request?

ZaneDubya commented 2 years ago

You are welcome to open a pull request. :) If you don't, I will try to take a look this weekend.

ZaneDubya commented 2 years ago

I see it, thank you. Will review this weekend. :)

ZaneDubya commented 2 years ago

Looks great - thanks!