ZaneDubya / UltimaXNA

Ultima Online client in C#/XNA
GNU General Public License v3.0
142 stars 73 forks source link

Allshow command crashes client on sphereserver #222

Closed robertdeclaux closed 9 years ago

robertdeclaux commented 9 years ago

I was using this command as an benchmark on client, i'm not sure which update effected this feature but it was working great when we were recording this (https://www.youtube.com/watch?v=gUfpQkLBdzE). Now when i send allshow command client immediately crashes. allshow

ZaneDubya commented 9 years ago

@robertdeclaux I know what's causing this, but don't have an easy fix in mind. Give me a few days...

ZaneDubya commented 9 years ago

@robertdeclaux Could we set up a debug session on your machine sometime this coming weekend?

robertdeclaux commented 9 years ago

Of course let me know when you are free

ZaneDubya commented 9 years ago

This is caused by SphereServer sending a mobile object before assigning the player's serial. It would be fixed by eliminating the PlayerMobile object altogether, replacing it with Mobile and using the IsClientEntity boolean to determine if we have a reference to the player's mobile.

ZaneDubya commented 9 years ago

Fixed in 01dcfc4.