Adding custom controls per label

ZaparooProject / zaparoo-designer

An app to package pdf to print labels

6 stars 5 forks source link

Adding custom controls per label #4

Closed asturur closed 10 months ago

asturur commented 10 months ago

This branch: template repaint and layout shift with 91 cards on screen

main branch: ... well main branch is a couple of MS faster.

And i don't explain that since i removed so much from the loops that this should be just quicker.

Maybe some useEffect is triggering twice.

Edits

ok now is faster, not that much faster...

removed fabricJS caching that for static canvases is not useful
removed debounce in favor of throttle
added a static boolean that will be set to false when template is changing and will avoid triggering more state updates during template swap ( that is async ).

netlify[bot] commented 10 months ago

Deploy Preview for nfc-retro-label-printer ready!

Name	Link
Latest commit	2b85fee8f77b8fc1334321a079103e8e740d3fc4
Latest deploy log	https://app.netlify.com/sites/nfc-retro-label-printer/deploys/65a661d5f541be00083d5455
Deploy Preview	https://deploy-preview-4--nfc-retro-label-printer.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

asturur commented 10 months ago

For whoever is watching, there should be a link to a test build in the PR that gives a general idea of what i m trying to achieve and opinions and suggestions are welcome. bonus: The app should be way faster now, the loading all white bug is found and fixed. not bonus: some images still fail to load sometimes for some unexplicable reason

asturur commented 10 months ago

feels an overall improvement, i m merging it

ZaparooProject / zaparoo-designer