Zapit-Optostim / zapit

General purpose optostimulation system
GNU Lesser General Public License v2.1
6 stars 1 forks source link

waveform_tests seemed to pass on Mac OS but at the rig in simulated mode it fails #105

Closed raacampbell closed 1 year ago

raacampbell commented 1 year ago

This should not be possible. The line obj.hZP.refPointsSample = obj.hZP.refPointsStereotaxic; ensures that no transformation is performed and so it should pass on all systems. Indeed the transform parameters are unity so it does nothing. Go back and check whether it even passes on MacOS in the first place.

raacampbell commented 1 year ago

Indeed the test passes on MacOS and it makes no different what the value of obj.hZP.refPointsStereotaxic is, which makes sense. But it does fail if laser min/max mW are different (they are should [0.0, 75.0] on MacOS) and also if either of the scan waveforms are inverted. Since neither is inverted on the MacOS machine. Also, the laser max control value should be 3.5.

We copy the waveform tests data into the test folder. Next we need to:

At this point it should be passing the test.