search

Zapit-Optostim / zapit

General purpose optostimulation system
GNU Lesser General Public License v2.1
6 stars 1 forks source link

There seems to be an issue with offsets L/R #113

Closed raacampbell closed 1 year ago

raacampbell commented 1 year ago

The points are not centred: image

Also the ROI drawing is shifted to the left too. It's maybe because the image is LR flipped in this case. So perhaps not everything is respecting that?

raacampbell commented 1 year ago

Indeed the ROI drawing is not respecting the LR flip. So let's sort that out first: 6038d0e6c949697d09ff07ebca4b158e6a6e240a

raacampbell commented 1 year ago

Seems that the beam points are directed to the original not cropped origin. Fixed: cf34b2637228a75493a2a82b3221da8a30e05fcf

raacampbell commented 1 year ago

It's better but not perfect. So don't close yet.

raacampbell commented 1 year ago

It's correct: it just looks off if there is a big difference between actual and target pos at first.