FEAT/Example - Download all trade data for an account timeline in JSON format plus all PDF files

Zarathustra2 / TradeRepublicApi

Unofficial trade republic API

MIT License

277 stars 68 forks source link

FEAT/Example - Download all trade data for an account timeline in JSON format plus all PDF files #21

Closed blessio closed 2 years ago

blessio commented 2 years ago

Hi,

Happy new year to everyone :-)

There are 2 commits - these are:

Improved Exception Interface (potentially a breaking change, although it should not be)
Processing of a server-side state "E"(not sure what it means - my understanding is: "Server-side critical error – please re-initiate the connection")

The second commit is a script that uses these changes to download in JSON format the complete timeline and the details for it plus ALL the PDF documents in a dedicated folder.

Best Regards, Blessio

Zarathustra2 commented 2 years ago

Wow, nice work. That looks awesome, pretty big changes!!

Let me know when u are comfortable and I will take a second look over it and then merge it!

blessio commented 2 years ago

Please have a second look and use all the time you need - the change in the API is somewhat risky... probably we can rename it public apiv2.0

Zarathustra2 commented 2 years ago

I am fine with the changes, like the new custom exceptions. As for server state E, I am also unsure but ur explanation makes sense! Can be merged IMO

Zarathustra2 commented 2 years ago

@blessio I can merge now if you'd like to

blessio commented 2 years ago

@Zarathustra2 I am fine with the merge- thanks :)