Zardoz89 / dcpu_vm

Another DCPU-16 Virtual Machine

http://zardoz89.github.io/dcpu_vm/

MIT License

6 stars 2 forks source link

Pull Request Lamogui #2

Closed lamogui closed 11 years ago

lamogui commented 11 years ago

Hello Zardoz Here are the change between my and your versions and my argument to conserve/removes somes things

Major Changes :

Remove Boost.

pro :

Big dependancy
There are no windows packages (I never found them)
I never compilated it
I never used it
Not easy for people who just want compile to see if working
We already use the c++11, i know: the threads are not well implemented well but there is a way to use sfml

against :

Your benchmark code is no more compatible

proposal : A DCPU Manager which manage dcpu calculation on 2 or 4 threads with libstd or sfml

Event Main loop on main thread (main function)

pro:

else the code is no compatible with OSX and maybe win32
Add need_render boolean on monitor

pro :

less calculation
can be used with graphic engine basicly if it doesn't want render

against :

render only the first frame

Minor change not very important

return Sf::Texture& instead of sf::Image*

pro :

avoid useless object between uint8_t* and sf::Texture and severals function calls
better speed optimisation (sfml doesn't have inline functions for sfImage and sf texture)
more compatible if SFML is removed

against :

monitor must allocate there uint8_t buffers like i do for the lem

More Emulator looks like...

made a very basic "posix looks like program" with options (example --debug or --monitor=) so we can add a benchmark option maybe...

add premake4

pro :

easy and light
no need installation premake4 is a single executable file included in the repo
one single script against :
new and not mostly used yet
i don't know if it works with linux and mac...
no force c++11 option yet