Zarius / Bukkit-OtherBlocks

OtherBlocks (now known as OtherDrops) plugin for Bukkit (dev build: https://www.mediafire.com/?i6ows1g6kus2o0l)
http://dev.bukkit.org/server-mods/otherdrops/
GNU General Public License v3.0
17 stars 17 forks source link

[Bug] Drops for named mobs broken in 2.8b.526 #222

Open charlie1990 opened 11 years ago

charlie1990 commented 11 years ago

Upon upgrading to this version my configuration for named mobs stopped working completely. Below is an example showing one of my named mobs drops and its normal counterpart. The named mob doesn't drop any of the items in its drop list but still drops the normal mobs drops(even though it has drop: nothing set) This config worked fine before.

CHICKEN:
    - action: MOBSPAWN
      drop: CHICKEN~Turkey
      chance: 10
    - tool: PLAYER
      drop: SEEDS/1-3
    - tool: PLAYER
      drop: WHEAT/1-2/25%
CHICKEN~Turkey:
    - tool: PLAYER
      drop: RAW_CHICKEN@1
      quantity: 1-2
    - drop: NOTHING
    - tool: PLAYER
      drop: FEATHER@1
      quantity: 1-4
Zarius commented 11 years ago

Seems to be working ok for me in the latest version - I'm about to push a new dev build, can you test with that?

I modified your config slightly to add names for the meat/feathers :)

  CHICKEN:
    - action: MOBSPAWN
      drop: CHICKEN~Turkey
      chance: 10
    - tool: PLAYER
      drop: SEEDS/1-3
    - tool: PLAYER
      drop: WHEAT/1-2/25%
  CHICKEN~Turkey:
    - tool: PLAYER
      drop: RAW_CHICKEN@1~Raw Turkey
      quantity: 1-2
    - drop: NOTHING
    - tool: PLAYER
      drop: FEATHER@1~Turkey Feather
      quantity: 1-4  
charlie1990 commented 11 years ago

Still not working for me, and now chickens aren't spawning at all(changed the spawn chance of turkey to 100 to test and tried spawning chickens with spawn eggs and it takes the egg but doesn't spawn a chicken or a turkey)

charlie1990 commented 11 years ago

This also didn't work (using named mob as a tool) I also tried it using lorename instead of putting the name directly in the tool.

PLAYER:
    - trigger: HIT
      tool: SKELETON~Energized Skeleton
      damage.victim: [LIGHTNING@1]
      chance: 25
charlie1990 commented 11 years ago

Even spawning in a "turkey" with /odd chicken~Turkey it still only drops the chickens drops(seeds and wheat)

EDIT: I believe the drops not working is a plugin conflict of some kind, I removed all of my plugins except OD, Essentials, Stackableitems, Multiverse, Bpermissions and Vault and the Turkey mobs dropped the raw turkey and turkey feathers but they also still dropped the normal chickens drops.

EDIT 2: Even with all of my plugins removed chickens still can't spawn(or turkeys) unless done with /odd. Even essentials /mob doesn't work.

Zarius commented 11 years ago

Yeah, lorenames don't work in a tool: parameter yet.

Hmm... have you tried using /killall first and then doing the testing?

Zarius commented 11 years ago

The turkey dropping the chicken drops is because the original "chicken" matches any type of chicken (named or unnamed). This is by design and I feel there's probably expectations both ways (ie. it matching any mob or just unnamed mobs).

I'm deciding between adding "CHICKEN~" to match unnamed mobs only or making "CHICKEN" match only unnamed mobs and have something else match any chicken. Could potentially do a config option.

CultistO commented 11 years ago

I would love to see something that matches any named mob as well. Especially useful when you use mobs named using %p and whatnot

charlie1990 commented 11 years ago

Ya I usually butcher my test server multiple times during testing I think I read about someone having a similar problem with OD not allowing mobs to spawn with certain settings on the bukkit dev page but I can't seem to find it now.

charlie1990 commented 11 years ago

I've managed to fix the problem with named mobs spawning however I'm still unable to give them drops.