search

Zarius / Bukkit-OtherBlocks

OtherBlocks (now known as OtherDrops) plugin for Bukkit (dev build: https://www.mediafire.com/?i6ows1g6kus2o0l)
http://dev.bukkit.org/server-mods/otherdrops/
GNU General Public License v3.0
17 stars 17 forks source link

Adding a PLAYER_LEAVE trigger #308

Open ShadedPL opened 10 years ago

ShadedPL commented 10 years ago

Like in the title, my request is pretty basic. Since I've discovered the power of the PLAYER_JOIN trigger I thought it could be even more powerful with the PLAYER_LEAVE one.

Best regards, this plugin is a musthave for every server! I love it

Zarius commented 10 years ago

Thanks for the request and glad you're enjoying OtherDrops. Can you give me an idea of how you're wanting to use a player leave trigger? On Jan 20, 2014 4:33 PM, "ShadedPL" notifications@github.com wrote:

Like in the title, my request is pretty basic. Since I've discovered the power of the PLAYER_JOIN trigger I thought it could be even more powerful with the PLAYER_LEAVE one.

Best regards, this plugin is a musthave for every server! I love it

— Reply to this email directly or view it on GitHubhttps://github.com/Zarius/Bukkit-OtherBlocks/issues/308 .

ShadedPL commented 10 years ago

I wanted to make custom messages when leaving also I have redstone circuits running that play custom sounds from my custom resource pack to players when somebody joins. I'm running a setblock command to power the command blocks with a redstone-block, which is working perfect with the PLAYER_JOIN command. Since people are enjoying the join feature I'm sure they would like the leave one. I'm also thinking of a scoreboard system that would count people joining and leaving and having the last player leave it would stop redstone circuits, run commands clearing laggy things, stop the server from pinging players, stop our custom mobspawning plugin from working etc. till a player joins again. I know that all those things could be made via seperate plugins but with OtherDrops having such a similar pattern to the players join I guess it would be no problem adding also the leave trigger.

To make this plugin even more powerful you should consider adding a command trigger. For example typing /test would perform a OtherDrops action.

CelticMinstrel commented 10 years ago

At that point I have to start wondering why OtherBlocks is the plugin you're using. If you want a scripting language for Minecraft to define your own arbitrary commands, shouldn't you be using something like... what was it called... CommandHandler or something? The one originally made by the creator of WorldEdit.

ShadedPL commented 10 years ago

I'm using OtherDrops for many things so what's the point of installing more plugins just for 1 additional purpose, when this theoretically could be easily implemented in Otherdrops. I know that there are plenty plugins out there but I don't see a reason why not to add such features into a plugin that already has a trigger code in it. It's just a suggestion I'm not forcing anybody to forge their plugin in a way that it wasn't ment to be. But my point is if you have a PLAYER_JOIN trigger (which in my opinion hasn't really anything to do with drops) so why not to take the trigger part of this plugin one step further?

CelticMinstrel commented 10 years ago

Seriously? That's the sort of logic that leads to a plugin that tries to do so much that it's not really very good at any of it. (Which, arguably, may have already happened with OtherBlocks, but whatever.)