Fix evaluated values - Githubissues

Zarkonnen / se-interpreter

Interpreter for Selenium Builder JSON scripts based on node.js and wd.

34 stars 31 forks source link

Closed davidlinse closed 10 years ago

davidlinse commented 10 years ago

This is an attempt to fix an issue described in sebuilder/se-builder#163 which allows comparison of evaluated values.

Example:

{
  "type": "verifyEval",
  "script": "return true;",
  "value": "true"
}

Before: Error: "true" does not match "true" After: true

Maybe you'll want to have a look .. ? The examples/tests/full_example.json runs fine ..

regards ~david

davidlinse commented 10 years ago

Hi, was there something wrong with this PR ? regards ~david

Zarkonnen commented 10 years ago

AFAIK it's not needed because I fixed it up in a slightly different way. Let me know if I got that wrong!