Zasilkovna / prestashop

module Packeta for PrestaShop 1.7
34 stars 27 forks source link

Chyba v modulu s Hummingbird sablonou #297

Open M4RtY opened 1 day ago

M4RtY commented 1 day ago

Implementuji vas modul pro Prestashop a mam nastavenou Hummingbird sablonu. Kdyz prepnu sablonu na "Classic", modul funguje jak ma, ovsem kdyz prepnu sablonu na Hummingbird, konzole mi vraci error:

Uncaught TypeError: module is null

Prestashop 8.1.7 Hummingbird 0.2.0 - https://github.com/PrestaShop/hummingbird/releases/tag/v0.2.0

Vse mam nastavene spravne, pokud prepnu sablonu, vraci to chybu module is null, v Classic sablone vse funguje spravne.

Stacktrace:

Uncaught TypeError: module is null
    initializePacketaWidget https://eshop:8890/modules/packetery/views/js/front.js?v=2.1.20:107
    onShippingLoadedCallback https://eshop:8890/modules/packetery/views/js/front.js?v=2.1.20:409
    <anonymous> https://eshop:8890/modules/packetery/views/js/front.js?v=2.1.20:78
    dispatch https://eshop:8890/themes/core.js:37
    handle https://eshop:8890/themes/core.js:37
    add https://eshop:8890/themes/core.js:37
    add https://eshop:8890/themes/core.js:10
    qe https://eshop:8890/themes/core.js:37
    each https://eshop:8890/themes/core.js:37
    each https://eshop:8890/themes/core.js:37
    qe https://eshop:8890/themes/core.js:37
    on https://eshop:8890/themes/core.js:37
    <anonymous> https://eshop:8890/themes/core.js:112
    <anonymous> https://eshop:8890/themes/core.js:311
    <anonymous> https://eshop:8890/themes/core.js:311
M4RtY commented 21 hours ago

Tak jsem v ramci debugovani prisel na to, ze ty moduly, ktere se nacitaji, se vazou na nazvy elementu, ktere vypisuji samotne dopravce, tudiz, pokud se zmeni sablona, nevybere se modul, protoze hleda napr:

getSelectedInput: function () {
    return $('.delivery-option input:checked');
}

Ovsem v Hummingbird sablone jsou divy pojmenovane jinak, takze fix je:

getSelectedInput: function () {
    return $('.delivery-options__item input:checked');
}

Dalo by se modul upravit tak, ze se vlozi podminka, ktera by napr. do konzole vypsala informaci, ze divy jsou pojmenovane jinak a nebo nekde nadefinovat nazvy techto modulu, kdyz se zmeni sablona?