Zathrox / Explorercraft

This is the main repo for all 1.16.5 code commits for Explorercraft
2 stars 5 forks source link

registered all features and added a structure example #16

Closed TelepathicGrunt closed 3 years ago

TelepathicGrunt commented 4 years ago

This can be cleaned up to a format you like better and stuff moved to where you like it. Though all features are now registered properly and I also threw in registering a surfacebuilder too although practically no mod ever pulls surfacebuilders from the registry. Though it doesn't hurt to register it just in case.

The reason why you weren't able to get the /locate command working with the wizard tower and dungeon was because those weren't actually structure. they were just normal Features. Structure are a subset of Features and are implemented in a different way.

To help you get started, I converted your Wizard Tower into a rough structure (based off of Vanilla's Igloo structure) and if you add it to a modded biome and at least one vanilla biome, it'll spawn and the /locate command can find it (has to be added to at least one vanilla biome when trying to spawn the structure in a vanilla dimension with vanilla chunkgenerator/biomeprovider because of a forge oversight with patching how vanilla finds and spawns structure)

However, the new Wizard Tower structure will not spawn and isn't placed perfectly but it is a start and you can play around with it! Though you can just ignore the part about creating structures if it's too much effort and just keep the wizard tower/dungeon as normal features like they currently are. I hope this helps!

TelepathicGrunt commented 4 years ago

Origin of pull request: https://github.com/Zathrox/Explorercraft/issues/15

Zathrox commented 3 years ago

TelepathicGrunt, thanks again for this! It was super helpful in 1.15 version on my mod and you modding tutorial I recently commented on was a huge help for 1.16! Figured out structures before I could even get features working! As i've updated and im registering all my structures, etc this isn't needed anymore!