Zayveeo5e / NP.VanillaPlus

Titanfall 2 mod that has just enough of Northstar.Client to allow client-side mods on official servers.
https://northstar.thunderstore.io/package/NanohmProtogen/VanillaPlus/
MIT License
11 stars 2 forks source link

Private game settings don't apply #13

Open Kyr4l opened 11 months ago

Kyr4l commented 11 months ago

How to reproduce :

image

itscynxx commented 11 months ago

I'll look into fixing this as I have time, I don't have a ton of free time this week, but it's more than last week

Not sure if Vanilla+ actually overrides anything for private matches though, will have to do a lot of checking to see if it does

Kyr4l commented 11 months ago

I'll look into fixing this as I have time, I don't have a ton of free time this week, but it's more than last week

Not sure if Vanilla+ actually overrides anything for private matches though, will have to do a lot of checking to see if it does

my guess is that it's northstar if it's not V+ overriding values, but in any case this is preventing private matches from being tweaked

itscynxx commented 11 months ago

Note: Plugins v3 has broken the code used in Vanilla+ for plugins v2

2.3 is now going to be a hotfix for that, and for mods like Speech Bubbles

2.4 will (hopefully) be this

itscynxx commented 11 months ago

Note: I have not forgotten about this Just had finishing week of a musical I was in the pit for finish this last Sunday, been crunching out assignments I didn't get to work on due to practicing that

Realistically, will do a deeper look at this tomorrow

Kyr4l commented 11 months ago

Note: I have not forgotten about this Just had finishing week of a musical I was in the pit for finish this last Sunday, been crunching out assignments I didn't get to work on due to practicing that

Realistically, will do a deeper look at this tomorrow

no pressure

itscynxx commented 10 months ago

I'm not entirely sure how possible this is to fix; Trying an older version of VanillaPlus that still used Northstar.Client, still was able to reproduce this issue

Trying Northstar with absolutely no core mods, I wasn't able to even get past the main menu, so I'm not entirely sure if this is specifically a VanillaPlus bug, or one that's just inside of Northstar

I've also compared a lot of files to their vanilla counterparts using VSCode, and most are relatively similar to the vanilla files (apart from Northstar functions, files added in Northstar, and files added by VanillaPlus)

itscynxx commented 10 months ago

I was correct in my being unable to find this inside of Northstar.Client (the core mods VanillaPlus is based off of)

Running Northstar with no core mods and no VanillaPlus (in fact, just no mods period), this was still an issue. I'll try to look into the NorthstarDLL code to find out why, however this is unrelated to VanillaPlus