search

ZcashFoundation / frost

Rust implementation of FROST (Flexible Round-Optimised Schnorr Threshold signatures) by the Zcash Foundation
https://frost.zfnd.org
Other
134 stars 50 forks source link

Resolve open `TODO`s in code #560

Open mpguerra opened 11 months ago

mpguerra commented 11 months ago

I think we might be able to do this one now that div_ceil has been stabilised in the latest rust release (1.73.0)?

https://github.com/ZcashFoundation/frost/blob/b37bde0d2a62ac9ce56639b819b5330db38883dd/frost-core/src/scalar_mul.rs#L24

conradoplg commented 10 months ago

We might want to wait a bit. If we do that now then everyone who uses our crates will need to use at least Rust 1.73.0 and that may be too strict. Maybe until the next Rust stable release?

mpguerra commented 10 months ago

Scheduling until after next Rust stable release on 2023.11.16

mpguerra commented 9 months ago

this blocks tagging the stable release

mpguerra commented 2 months ago

Let's wait until ECC crates are on 1.73.0 as their MSRV