search

ZcashFoundation / frost

Rust implementation of FROST (Flexible Round-Optimised Schnorr Threshold signatures) by the Zcash Foundation
https://frost.zfnd.org
Other
133 stars 50 forks source link

Reject identity in Group::serialize #667

Closed doutv closed 2 months ago

doutv commented 3 months ago

In current RFC document 3.1, page 10:

SerializeElement(A): Maps an Element A to a canonical byte array buf of fixed length Ne. This function raises an error if A is the identity element of the group.

Serialize a Group identity element should raise error.

Related PR: https://github.com/cfrg/draft-irtf-cfrg-frost/pull/306 https://github.com/ZcashFoundation/frost/pull/145

conradoplg commented 2 months ago

Thank you for reporting this! It was good timing since the next release will be an API-breaking one.