cargo test -p frost-core was failing because the benchmark was failing to build, which in turn was being caused by the criterion dependency not being included when compiling without features.
This was not being caught because on CI we just use cargo test, which merges all features and would end up including criterion.
This was also not being caught by the all-features test because we were only doing build (which does not build benchmarks) and not test (which does build benchmarks).
This fixes the issue, and adds test-all-features to CI, which already works on each crate separately.
cargo test -p frost-corewas failing because the benchmark was failing to build, which in turn was being caused by thecriteriondependency not being included when compiling without features.This was not being caught because on CI we just use
cargo test, which merges all features and would end up includingcriterion.This was also not being caught by the all-features test because we were only doing
build(which does not build benchmarks) and nottest(which does build benchmarks).This fixes the issue, and adds test-all-features to CI, which already works on each crate separately.