ZcashFoundation / zebra

Zcash - Financial Privacy in Rust 🦓
https://zfnd.org/zebra/
Apache License 2.0
408 stars 99 forks source link

Add protocol version information to fields on `NetworkParameters` #8367

Open arya2 opened 6 months ago

arya2 commented 6 months ago

Motivation

We want to make these values configurable on Testnets:

See https://github.com/ZcashFoundation/zebra/pull/7924#discussion_r1385877140.

Outdated: These have already been added. - [FUNDING_STREAM_HEIGHT_RANGES](https://github.com/ZcashFoundation/zebra/blob/main/zebra-consensus/src/parameters/subsidy.rs#L107) - [FUNDING_STREAM_ADDRESSES](https://github.com/ZcashFoundation/zebra/blob/main/zebra-consensus/src/parameters/subsidy.rs#L116)

Possible Design

Check what values zcashd uses for Regtest and either:

arya2 commented 3 months ago

This isn't a priority right now

arya2 commented 1 month ago

We still want to move INITIAL_MIN_NETWORK_PROTOCOL_VERSION to a field on testnet::Parameters.