search

ZcashFoundation / zebra

Zcash - Financial Privacy in Rust 🦓
https://zfnd.org/zebra/
Apache License 2.0
407 stars 98 forks source link

Introduce initial ZSA support in Zebra (draft PR for CI checks) #8872

Open dmidem opened 1 week ago

dmidem commented 1 week ago

This draft PR introduces initial support for Zcash Shielded Assets (ZSA) in the Zebra codebase. The primary goal of this PR is to run CI checks provided by the ZcashFoundation repository to verify compilation correctness and execute unit and integration tests.

mpguerra commented 1 week ago

@dmidem as discussed during our call, this will need to have its conflicts resolved before we can run CI on it :)

arya2 commented 5 days ago

It's not possible to fix all of the complaints from cargo-deny until the changes in librustzcash have been published, and not urgent to fix any of them, but see Continuous Integration in the Zebra book for how to fix duplicate dependencies in the deny.toml checks for later.

Note: at least the windows-sys entry should be updated when updating Zebra's dependencies on main.

Building zebra-chain without any default features seems to be the only failure that needs fixing: https://github.com/ZcashFoundation/zebra/actions/runs/11015467979/job/30589574007?pr=8872

@gustavovalverde Is there anything else we could try to get this one working?

mpguerra commented 5 days ago

I think probably it's good enough to see where it's failing now and see if there are any actionable failures on the QEDIT side, e.g maybe https://github.com/ZcashFoundation/zebra/actions/runs/11015467979/job/30589574007?pr=8872